fix: move h1 tags to template #6654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Display
Template::Toolkit
alexgarel
approved these changes
Apr 20, 2022
lib/ProductOpener/Display.pm
Outdated
| @@ -1434,10 +1433,10 @@ sub display_text($) | |||
| # wikipedia style links [url text] | |||
| $html =~ s/\[(http\S*?) ([^\]]+)\]/<a href="$1">$2<\/a>/g; | |||
|
|
|||
|
|
|||
| # Remove the title from the content to put it in the title field | |||
| if ($html =~ /<h1>(.*)<\/h1>/) { | |||
There was a problem hiding this comment.
Make a non greedy expression (use ?) to handle case of multiple h1
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes to put the generation of
<h1>title tags for all pages in templates.