feat: add link to learn more about nutriscore + ecoscore #6701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📖 Knowledge Panels
|
Kudos, SonarCloud Quality Gate passed!
|
alexgarel
approved these changes
Apr 26, 2022
| "element_type": "text", | ||
| "text_element": { | ||
| "html": ` | ||
| <p>→ <a href="/nutriscore">[% lang('nutriscore_learn_more') %]</a></p> |
There was a problem hiding this comment.
Why not url_for_text("nutriscore") here ?
There was a problem hiding this comment.
url_for_text() currently only works for the Eco-Score text, the /nutriscore text URL is not localized, it's the same for all languages.
=head2 url_for_text ( $textid )
Return the localized URL for a text. (e.g. "data" points to /data in English and /donnees in French)
=cut
# Note: the following urls are currently hardcoded, but the idea is to build the mapping table
# at startup from the available translated texts in the repository. (TODO)
my %urls_for_texts = (
"ecoscore" => {
en => "eco-score-the-environmental-impact-of-food-products",
de => "eco-score-die-umweltauswirkungen-von-lebensmitteln",
es => "eco-score-el-impacto-medioambiental-de-los-productos-alimenticios",
fr => "eco-score-l-impact-environnemental-des-produits-alimentaires",
it => "eco-score-impatto-ambientale-dei-prodotti-alimentari",
nl => "eco-score-de-milieu-impact-van-voedingsproducten",
pt => "eco-score-o-impacto-ambiental-dos-produtos-alimentares",
},
);
sub url_for_text($) {
my $textid = shift;
# remove starting / if passed
$textid =~ s/^\///;
if (not defined $urls_for_texts{$textid}) {
return "/" . $textid;
}
elsif (defined $urls_for_texts{$textid}{$lc}) {
return "/" . $urls_for_texts{$textid}{$lc};
}
elsif ($urls_for_texts{$textid}{en}) {
return "/" . $urls_for_texts{$textid}{en};
}
else {
return "/" . $textid;
}
}
teolemon
approved these changes
Apr 26, 2022
Nothing is happening, it's kept as-is. This PR adds a similar "Learn more about... " link in the Nutri-Score and Eco-Score panels. |
|
Can we close this? |
|
@stephanegigandet I can't see it in Smoothie. Has it been deployed ? Do we need tweaking client side ? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6689
related to #6679