fix: tests if variable defined before use

[dipietroR]

On the main page I was seeing the following warning:

[Sun May  1 16:45:15 2022] -e: Use of uninitialized value $current_link_query in concatenation (.) or string at /opt/product-opener/lib/ProductOpener/Display.pm line 5411.

And on the search page I was seeing:

[Sun May  1 16:54:12 2022] -e: Use of uninitialized value $current_link in concatenation (.) or string at /opt/product-opener/lib/ProductOpener/Display.pm line 5411.

This seems to be because they weren't being tested for definition, which was happening later on in the code.

[stephanegigandet]

That would work, but we won't log the info that $current_link is undefined.

There's a way to log multiple variables in a structured way. Here is an example from elsewhere in the code:

$log->info("displaying text from file", { cc => $cc, lc => $lc, lang => $lang, textid => $textid, textlang => $text_lang, file => $file }) if $log->is_info();

So instead of having $current_link and $current_link_query inside the debug text, we can pass them in the 2nd parameter.

Could you use that instead? Thank you!

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[stephanegigandet]

Thank you very much @dipietroR !