-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improvements to Nutri-Score panel, remove extended Eco-Score panel #6748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stephanegigandet
commented
May 6, 2022
- Remove extended Eco-Score panel, fixes disable the customized eco-score card for the time being #6678
- Record and display all the reasons why we couldn't compute a Nutri-Score, and only the first one, fixes The Nutri-Score info message in the sub-knowledge panel is not correct (It forgets nutrition is needed too) #6532
- Create a Nutri-Score knowledge panel even if we could not compute it. - fixes Missing summary for nutrition on products without nutrition #6585
alexgarel
approved these changes
May 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Display
Food.pm
📖 Knowledge Panels -
https://wiki.openfoodfacts.org/Knowledge_panels
📖 Knowledge Panels
https://wiki.openfoodfacts.org/Knowledge_panels
Tags
🧬 Taxonomies
https://wiki.openfoodfacts.org/Global_taxonomies
🧪 tests
Translations
We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.