-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add back nutrition facts table title in knowledge panel #6867
Conversation
templates/api/knowledge-panels/health/nutrition/nutrition_facts_table.tt.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org>
Kudos, SonarCloud Quality Gate passed!
|
Maybe adding a TODO "remove later" would make us remember to change it? |
@VaiTon : What would need to be changed? It's a good thing to have table titles. They don't have to be displayed by the client, but they are useful for screen readers. On the web, we use it to set an aria-label:
|
I thought we moved them here openfoodfacts-server/templates/api/knowledge-panels/health/nutrition/nutrition_facts_table.tt.json Line 9 in d9f898f
If it's still useful, let's keep it! |
Right, we added the title elsewhere, but we still need a table title, even if it's shown only for screen readers. |
The openfoodfacts-dart package expects a non null title for the table elements in knowledge panels. This adds back the table title that was removed in #6839
Hot fix deployed in production as it was breaking scanning and searching in Smoothie.
Related:
openfoodfacts/smooth-app#2203
openfoodfacts/openfoodfacts-dart#477