-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: suggest fuzzy + limit as a param #6887
Conversation
It would be cool to add tests, but I don't know if I have the time because it will require making a sub to be able to test with a fake taxonomy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @alexgarel!
If I sum up, now there's
- the fuzzy search
- a new optional
limit
parameter (default is25
, max is400
)
cgi/suggest.pl
Outdated
push @suggestions_c, $tag; | ||
$suggestions_count++; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kudos, SonarCloud Quality Gate passed! |
PR updated to only count for "start with" match to limit traversal. |
fixes: openfoodfacts/openfoodfacts-dart#465
Also add fuzzy searching.