fix: uninitialized value #6912
Merged
fix: uninitialized value #6912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This code was to have a special share button on some browsers, it was a feature @hangy added 6 years ago. On Android on Chrome, it displays a "Share" button at the bottom of the screen. We should fix the link though. It would be good to add some comments so that we remember what it is, I had completely forgotten about it.
|
Add conditional as without it this will make a dead link resulting in a 404
dipietroR
force-pushed
the
uninitialized-value
branch
from
4f2e51b to
401e232
Compare
|
OK, this should give the code a functional link. Does this seem right to you? |
Yes, definitely! |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add conditional as without it this will make a dead link resulting in a 404
It is not clear to me what the link in this section does and it is not visible on the page. It may be used for search engines?
If
$request_ref->{current_link_query_display}isn't defined, and we select the link in the source, it leads to a 404. As it stands without that defined it appears to be broken, though I'm not certain that we don't want this information here even with a dead link. Perhaps we want something more like$request_ref->{current_link}?