Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support for some common and popular US dairy ingredients #6955

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

yuktea
Copy link
Contributor

@yuktea yuktea commented Jun 24, 2022

What

This PR extends ingredient analysis support for,

  • cultured cream,
  • sweet cream buttermilk,
  • heavy cream,
  • cream cheese

Why

us-filter:cream-status:unknown

@yuktea yuktea requested a review from a team as a code owner June 24, 2022 08:53
@github-actions github-actions bot added 🧪 tests categories 🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels Jun 24, 2022
@yuktea yuktea changed the title fix: support for some common and popular US dairy products fix: support for some common and popular US dairy ingredients Jun 24, 2022
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephanegigandet
Copy link
Contributor

@yuktea : you can update the test results by opening a terminal in the backend container, and executing ./update_tests_results.sh in the /t directory.

@yuktea
Copy link
Contributor Author

yuktea commented Jun 24, 2022

@yuktea : you can update the test results by opening a terminal in the backend container, and executing ./update_tests_results.sh in the /t directory.

This sounds useful

@yuktea yuktea marked this pull request as draft June 24, 2022 11:19
@github-actions github-actions bot added 🧬 Taxonomies - Rebuild Taxonomies are compiled before they can be used. and removed 🧬 Taxonomies - Rebuild Taxonomies are compiled before they can be used. labels Jun 24, 2022
@yuktea yuktea force-pushed the feat/common-american-dairy-creams branch from 3fd3300 to a68f939 Compare June 24, 2022 14:31
fix: added support for common us dairy ingredients

- cream cheese is a synonym to "cream cheese"
- heavy cream is a type of cream usually used for whipping and dessert, it's just fresh cream but with less water content
- cultured cream is mostly just sour cream

add test

test: add test for recognition of "heavy cream"

fix: add heavy cream to taxonomy

fix: add "heavy cream"

fix: test

test

revert: some unneeded changes

fix: cream cheese is under cheeses

fix: add test for cream cheese

clean-up: removing unnecessary tests before merge
@yuktea yuktea force-pushed the feat/common-american-dairy-creams branch from 92eb27f to 2971dc8 Compare June 24, 2022 15:05
@yuktea yuktea marked this pull request as ready for review June 24, 2022 15:06
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stephanegigandet stephanegigandet merged commit 24f52cb into main Jun 24, 2022
@stephanegigandet stephanegigandet deleted the feat/common-american-dairy-creams branch June 24, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categories 🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
Development

Successfully merging this pull request may close these issues.

2 participants