feat: parse origins of ingredients field

[stephanegigandet]

Fixes partially #4461 (we could add support for more ways to describe ingredients, like "Strawberries from Spain").

Needed in particular for one producer who sent us data in the origins of ingredients field, in order to have it used for the Eco-Score computations.

[alexgarel]

Suggested change

	Used to find % values, language specific.
	Used to find % values, language specific. It MUST capture the percent digits.

[alexgarel]

If it's not too much I would like a refactor to avoid duplicating.

[alexgarel]

I'm thinking how to avoid repeating that stuff twice in the code. The risk is that we correct it on some place but not the other.

Why don't we put this kind of simple condition in a function. It could return undef if no match, else a result as a hash map.
If all conditions are treated the same you can continue with next function while your result in undefined, and unpack the result at the end. I think it's easier to read, we could even just list the functions and loop (adding percent expression when needed)

[alexgarel]

The very least we can do is add those regular expressions as constants or as functions that return them (for the one which needs percent expression).

[alexgarel]

Also @stephanegigandet what about using more verbose regexp in our code: https://perldoc.perl.org/perlre#/x-and-/xx

This is very handy to comment what you are doing in an expression.

[alexgarel]

Let's merge and refactor later on as proposed by @stephanegigandet

[stephanegigandet]

Also @stephanegigandet what about using more verbose regexp in our code: https://perldoc.perl.org/perlre#/x-and-/xx

This is very handy to comment what you are doing in an expression.

Yes, we should do that, definitely.

[stephanegigandet]

Thanks, opened an issue for not forgetting it: #7028

And start of refactor is here: #7026

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information