Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: uncommenting severity 4 rules in .perlcriticrc #7109

Merged
merged 1 commit into from
Jul 22, 2022
Merged

feat: uncommenting severity 4 rules in .perlcriticrc #7109

merged 1 commit into from
Jul 22, 2022

Conversation

dipietroR
Copy link
Contributor

Uncommenting severity 4 rules and adding [Subroutines::RequireFinalReturn], which requires an explicit return at the end of each subroutine.

@dipietroR dipietroR requested a review from a team as a code owner July 20, 2022 22:54
@dipietroR dipietroR force-pushed the perlcritic-severity4 branch from ae58441 to c11bb92 Compare July 21, 2022 15:02
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

alexgarel
alexgarel approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good move :-)

@alexgarel alexgarel merged commit 7599272 into main Jul 22, 2022
@alexgarel alexgarel deleted the perlcritic-severity4 branch July 22, 2022 16:35
@alexgarel alexgarel mentioned this pull request Jul 22, 2022
Merged
LandonPattison pushed a commit that referenced this pull request Jul 24, 2022
@dipietroR @LandonPattison
feat: uncommenting severity 4 rules in .perlcriticrc (#7109)
f620b02 
feat: uncommenting severity 4 rules in .perlcriticrc
LandonPattison pushed a commit that referenced this pull request Jul 25, 2022
@dipietroR @LandonPattison
feat: uncommenting severity 4 rules in .perlcriticrc (#7109)
eb5d3ca 
feat: uncommenting severity 4 rules in .perlcriticrc
LandonPattison pushed a commit that referenced this pull request Jul 25, 2022
@dipietroR @LandonPattison
feat: uncommenting severity 4 rules in .perlcriticrc (#7109)
042cea3 
feat: uncommenting severity 4 rules in .perlcriticrc
LandonPattison pushed a commit that referenced this pull request Jul 25, 2022
@dipietroR @LandonPattison
feat: uncommenting severity 4 rules in .perlcriticrc (#7109)
e45d111 
feat: uncommenting severity 4 rules in .perlcriticrc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@dipietroR dipietroR

Labels
None yet
Projects
old prs
Status: No status
Outreachy 2022
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dipietroR @alexgarel