Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Social media link preview shows old logo Fixes #7059 #7177

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

ferb7o2
Copy link
Contributor

@ferb7o2 ferb7o2 commented Aug 4, 2022

What

  • Created and added new 420x420 logo image, because of og:image requirements

  • Updated source path of tags to include new image

Related issue(s) and discussion

@ferb7o2 ferb7o2 requested a review from a team as a code owner August 4, 2022 10:24
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Note that the .po files are generated by Crowdin from common.pot so it's also possible to change only common.po + en.po

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stephanegigandet stephanegigandet merged commit 6eaa392 into openfoodfacts:main Aug 24, 2022
LandonPattison pushed a commit that referenced this pull request Aug 27, 2022
Added a new 420x420 logo img and updated old <meta property='og:image' > tags to include new logo img
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Replace the logo in the social media preview
2 participants