-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Connect to Redis for populating search #7239
Conversation
@simonj2 really good. I put it on "draft" state to be clear it's not yet ready. |
d950746
to
2daefca
Compare
@stephanegigandet @teolemon - this is ready for review now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simonj2 thanks a lot for this PR, nice work.
I would just prefer we keep connection, and move it to a specific file (but you may argue against it :-) )
e2c9055
to
ed6e177
Compare
Updating to draft since I'm having some trouble getting this to work, and want to use this as a platform to ask for some 👀 |
This is ready for review again and passing all manual testing. Thanks for the help @alexgarel + @stephanegigandet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks a lot @simonj2 :-) |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
I will merge, but for it to be effective we will have to change deployment CI to add redis parameter, but I'll do it on a separate PR. |
What
This PR connects the Server to the search service so that new writes are populated. See the search service here: https://github.com/openfoodfacts/openfoodfacts-search
eval
statement, so there shouldn't be any effect if the Redis instance is down (such as now).