-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taxonomy: Adding Dutch translations for taxonomies #7268
taxonomy: Adding Dutch translations for taxonomies #7268
Conversation
taxonomies/categories.txt
Outdated
@@ -68,6 +68,7 @@ fr:Gressins artisanaux | |||
hu:Kézzel készített termékek | |||
it:Grissini artigianali, Grissini fatti a mano | |||
nl:Handgemaakte broodstengels | |||
nl_be:Handgemaakte broodstengels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we do not support language variants, so only nl: is used, nl_be: will not have an effect (it's ok to add it though).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we do not support language variants, so only nl: is used, nl_be: will not have an effect (it's ok to add it though).
Ohh, I didn't know! Thanks for letting me know!
I see you have issues "conflicting files". Usually this happens when other persons have been working on the same files. So it depends when you downloaded your versions. I'll have a look. |
Only the primary files need to have translations added. So ending in |
in |
For category entries you noticed already an issue: plural or singular? I tend to use plural, so you can read an entry as: "Dit product behoort in het vak Spaanse likeuren". But sometimes this does not work well. In any case I also add the singular form as synonym. |
To check the conflicts do In the file you will find something like:
Under HEAD is your change and above main what is now the file. In this case there is real issue: so edit out the line with HEAD and everything below your change (=== and >>> main). If there is an issue you can merge the new and old versions and remove the <<<,, === and >>> lines. |
Thanks for your work!!! |
Okay, I will remember! |
Thanks for the feedback, just did some taxonomies, but I didn't know how to save them! |
Kudos, SonarCloud Quality Gate passed! |
@Annieieieie @aleene : I don't speak Dutch but this one looks good to me, can we merge it? Or are other changes needed? |
Ok with me |
I think it's good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
What
Added Dutch taxonomies
Screenshot
Related issue(s) and discussion