Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing the old logos for OBF, OPF, OPFF #7276

Merged
merged 20 commits into from
May 25, 2023
Merged

Conversation

teolemon
Copy link
Member

@teolemon teolemon commented Aug 30, 2022

What

  • fix: removing the old logo for flavors

Why

We now have a language independant logo for all flavors, and translators keep translating to logo that don't exist, provoking test failures

Part of

@teolemon teolemon requested a review from a team as a code owner August 30, 2022 16:23
@github-actions github-actions bot added 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org labels Aug 30, 2022
@github-actions github-actions bot added the 📸 Open Products Facts Our project to increase the lifespan of objects. https://world.openproductsfacts.org label Aug 30, 2022
@github-actions github-actions bot added the 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org label Aug 30, 2022
@github-actions github-actions bot force-pushed the l10n_main branch 2 times, most recently from 748d3b6 to baa12a5 Compare September 1, 2022 03:48
po/common/hi.po Outdated Show resolved Hide resolved
Base automatically changed from l10n_main to main September 3, 2022 13:53
@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Sep 4, 2022
po/openfoodfacts/af.po Outdated Show resolved Hide resolved
po/openfoodfacts/af.po Outdated Show resolved Hide resolved
@teolemon teolemon requested a review from VaiTon September 5, 2022 13:40
@teolemon
Copy link
Member Author

teolemon commented Sep 5, 2022

@VaiTon Can you validate ? Also, Please do not remerge l10n_main into this.

@github-actions github-actions bot removed the 💥 Merge Conflicts 💥 Merge Conflicts label Sep 5, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@teolemon teolemon changed the title fix: removing the old logo for flavors fix: removing the old logos for OBF, OPF, OPFF Oct 30, 2022
@alexgarel
Copy link
Member

alexgarel commented Dec 20, 2022

@teolemon why wasn't this branche squashed and merged ?

@teolemon teolemon enabled auto-merge (squash) May 25, 2023 09:35
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@teolemon teolemon merged commit ea5a5c7 into main May 25, 2023
@teolemon teolemon deleted the removing-old-logo-flavors branch May 25, 2023 10:00
MonalikaPatnaik pushed a commit to MonalikaPatnaik/openfoodfacts-server that referenced this pull request May 31, 2023
* l10n: New Crowdin translations by Github Action

* Update po/common/fr.po

* fix: uk

* Update af.po

* Update af.po

* fix: removing the old logo for flavors

* Update en.po

* Update openproductsfacts.pot

* Update openpetfoodfacts.pot

* Update openbeautyfacts.pot

* Update openfoodfacts.pot

* l10n: New Crowdin translations by Github Action

* Update af.po

* Update uk.po

* Update no.po

* ci: Fix Test

* Apply suggestions from code review

---------

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: VaiTon <eyadlorenzo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org 📸 Open Products Facts Our project to increase the lifespan of objects. https://world.openproductsfacts.org Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants