Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taxonomy: Added some Dutch synonyms and translations #7281

Merged
merged 6 commits into from
Oct 6, 2022
Merged

taxonomy: Added some Dutch synonyms and translations #7281

merged 6 commits into from
Oct 6, 2022

Conversation

Annieieieie
Copy link
Contributor

What

Added some Dutch synonyms and translations

Related issue(s) and discussion

  • Fixes #[ISSUE NUMBER]

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

danizavtz
danizavtz reviewed Aug 31, 2022
View reviewed changes
Copy link

@danizavtz danizavtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added some comments.

taxonomies/old/containers.txt Show resolved Hide resolved
taxonomies/old/containers.txt
pt:Cortiça
hu:Dugó
wikidata:en:Q49444

fr:Puisette
hu:Fa


Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I my opinion this blank line can be removed, it is generating a diff in the code difficulting review for a thing that does not changed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danizavtz FYI, in github when you review PRs you can set not to see white space changes
Capture d’écran du 2022-09-06 16-18-29

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll do it next review.

@aleene
Copy link
Contributor

aleene commented Aug 31, 2022

Noticed that you made changes to the folders old and unused. Probably not useful at the moment. Not sure why these exist.

@teolemon teolemon changed the title Taxonomy Dutch Taxonomy: Dutch Sep 1, 2022
@stephanegigandet stephanegigandet changed the title Taxonomy: Dutch taxonomy: Dutch Sep 5, 2022
@stephanegigandet
Copy link
Contributor

The packaging_shapes taxonomy test fails because "pak" is associated to both en:pack and en:box.

ERROR - nl:pak already is a synonym of nl:pak for entry en:pack - nl:pak cannot be mapped to entry en:box / nl:doos

Unfortunately we cannot have the same translation for 2 different entries.

@teolemon teolemon changed the title taxonomy: Dutch taxonomy: Added some Dutch synonyms and translations Sep 5, 2022
@teolemon teolemon added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org labels Sep 5, 2022
@aleene
Copy link
Contributor

aleene commented Sep 5, 2022

Remove nl:Pak then.

@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Sep 6, 2022
@github-actions github-actions bot removed the 💥 Merge Conflicts 💥 Merge Conflicts label Oct 5, 2022
@aleene aleene requested review from alexgarel and danizavtz October 5, 2022 14:31
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

stephanegigandet
stephanegigandet approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephanegigandet stephanegigandet merged commit 4aae61f into openfoodfacts:main Oct 6, 2022
@alexgarel alexgarel mentioned this pull request Oct 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

@alexgarel alexgarel Awaiting requested review from alexgarel

@danizavtz danizavtz Awaiting requested review from danizavtz

Assignees

@Annieieieie Annieieieie

Labels
🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Annieieieie @aleene @stephanegigandet @alexgarel @danizavtz @teolemon