-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Label parenting #7321
fix: Label parenting #7321
Conversation
For parenting, the taxonomy building still works if you use a synonym or a translated name for the parent. |
@@ -798,7 +798,7 @@ bg:Без пшеница | |||
de:Ohne Weizen | |||
nl:Zonder graan | |||
|
|||
en:No gluten, Gluten-free, Without gluten, Gluten-free-food, free of gluten, Naturally gluten free, Gluten free, ni gluten |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For allergens, antibiotics etc. the ingredients parsing code expects the "No something" to be the canonical entry.
There's a comment about that at the top of the file:
# For labels that indicate the absence of something, in English, always make "No something" the first entry, and make "Something-free", "Without something" synonyms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can add that it's required by the ingredients parsing code.
@stephanegigandet what is the status on this PR ? |
I think I have to revert some changes and adapt the children instead. |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
What
Repaired some wrong parenting.
Should these not have been intercepted by a test?