Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taxonomy: added some ingredients for crunchy almonds - spar in HR #7332

Merged
merged 1 commit into from
Sep 13, 2022
Merged

taxonomy: added some ingredients for crunchy almonds - spar in HR #7332

merged 1 commit into from
Sep 13, 2022

Conversation

stephanegigandet
Copy link
Contributor

Tried to fix conflict on PR by @benbenben2 : #7327

@github-actions github-actions bot added 🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels Sep 13, 2022
@stephanegigandet stephanegigandet mentioned this pull request Sep 13, 2022
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@benbenben2
Copy link
Collaborator

@stephanegigandet
yes, it looks good!

@benbenben2
Copy link
Collaborator

@stephanegigandet

I approved
Should I "squash and merge" as well?

@alexgarel alexgarel merged commit d7b8583 into main Sep 13, 2022
@alexgarel alexgarel deleted the benbenben2-taxonomy_crunchy_almonds_spar_hr2 branch September 13, 2022 13:24
@alexgarel
Copy link
Member

@benbenben2 do not hesitate to squash and merge indeed, taking attention to the comments (avoid keeping the garbage)

@alexgarel alexgarel mentioned this pull request Sep 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbenben2 benbenben2 benbenben2 approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephanegigandet @benbenben2 @alexgarel