feat: improved parsing of origins of ingredients #7398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stephanegigandet
commented
Sep 26, 2022
stephanegigandet
commented
- refactored the construction of the list of regexps that we use to match entries of a taxonomy in a string. This is used in particular for ingredients parsing, and packaging parsing. There was a lot of code that I had copy/pasted and modified. The common code is now in Tags.pm.
- we now match things like "Origins of the ingredients: Spain, Italy and South America" or "Strawberries from France or Belgium".
- added tests to cover the new matches
- moved some tests out of /t and /test to /tests
github-actions
bot
added
🥗 Ingredients
📦 Packaging
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.