Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Totano to ingredients taxonomy #7438

Merged
merged 4 commits into from
Oct 5, 2022
Merged

feat: add Totano to ingredients taxonomy #7438

merged 4 commits into from
Oct 5, 2022

Conversation

VaiTon
Copy link
Member

@VaiTon VaiTon commented Oct 4, 2022

No description provided.

@github-actions github-actions bot added 🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels Oct 4, 2022
@VaiTon VaiTon requested review from aleene and teolemon October 4, 2022 17:36
aleene
aleene requested changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@aleene aleene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the english name as well en:European flying squid and the latin name.
On the wikidata page you can also link back to OFF by adding a parameter there.

@VaiTon
Copy link
Member Author

VaiTon commented Oct 4, 2022

@aleene on wikidata I only see "OpenFoodFacts category". Is there another one for ingredients?

@aleene
Copy link
Contributor

aleene commented Oct 4, 2022

Search for open food (with the space)

@VaiTon VaiTon requested a review from aleene October 4, 2022 18:04
aleene
aleene requested changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@aleene aleene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Language code is la: not lat:

@aleene
Copy link
Contributor

aleene commented Oct 4, 2022

Wonder is we should use the latin name for all fish entries.

@VaiTon VaiTon requested a review from aleene October 5, 2022 16:16
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@VaiTon VaiTon merged commit f9e0986 into main Oct 5, 2022
@VaiTon VaiTon deleted the taxo/totano branch October 5, 2022 20:30
@alexgarel alexgarel mentioned this pull request Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleene aleene aleene approved these changes

@teolemon teolemon Awaiting requested review from teolemon

Assignees

@VaiTon VaiTon

Labels
🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VaiTon @aleene