Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taxonomy: improve category taxonomy #7456

Merged
merged 1 commit into from
Oct 11, 2022
Merged

taxonomy: improve category taxonomy #7456

merged 1 commit into from
Oct 11, 2022

Conversation

raphael0202
Copy link
Contributor

@raphael0202 raphael0202 commented Oct 7, 2022 •
edited
Loading

Improvements of the category taxonomy, spotted when working on the category matching algorithm.

  • en:Teas should be below en:Tea-based beverages instead of the more generic category en:Beverages
  • en:Cereal pastas are also en:Pastas
  • add italian translations

@raphael0202 raphael0202 added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧬 Taxonomies - Translation labels Oct 7, 2022
@raphael0202 raphael0202 requested a review from VaiTon October 7, 2022 15:44
@raphael0202 raphael0202 force-pushed the improve-taxonomies branch 2 times, most recently from c5bd440 to eae4518 Compare October 7, 2022 16:11
@alexgarel alexgarel changed the title feat: improve category taxonomy taxonomy: improve category taxonomy Oct 7, 2022
@alexgarel
Copy link
Member

@raphael0202 FYI changed title because we have a specific prefix for taxonomy changes (so that they go in the right section in release please)

alexgarel
alexgarel reviewed Oct 7, 2022
View reviewed changes
taxonomies/categories.txt Outdated Show resolved Hide resolved
aleene
aleene reviewed Oct 7, 2022
View reviewed changes
Copy link
Contributor

@aleene aleene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The easter chocolate eggs can be different from chocolate eggs. Maybe introduce a parent for chocolate eggs?

@aleene
Copy link
Contributor

aleene commented Oct 8, 2022

Need to add a test so that this can not be changed.

@raphael0202
feat: improve category taxonomy
03c5973 
- en:Teas should be below en:Tea-based beverages instead of the more
  generic category en:Beverages
- en:Cereal pastas are also en:Pastas
- Peanut butters can also be considered as en:Nut butters
- add italian translations
@raphael0202
Copy link
Contributor Author

The easter chocolate eggs can be different from chocolate eggs. Maybe introduce a parent for chocolate eggs?

Good idea, I've added the category

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@raphael0202 raphael0202 merged commit 7b5c802 into main Oct 11, 2022
@raphael0202 raphael0202 deleted the improve-taxonomies branch October 11, 2022 09:51
@alexgarel alexgarel mentioned this pull request Oct 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

@VaiTon VaiTon Awaiting requested review from VaiTon

@aleene aleene Awaiting requested review from aleene

@alexgarel alexgarel Awaiting requested review from alexgarel

Assignees

@raphael0202 raphael0202

Labels
categories 🧬 Taxonomies - Translation 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raphael0202 @alexgarel @aleene @stephanegigandet