Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add body parameter to auth.pl #7471

Merged
merged 3 commits into from
Oct 11, 2022
Merged

fix: add body parameter to auth.pl #7471

merged 3 commits into from
Oct 11, 2022

Conversation

stephanegigandet
Copy link
Contributor

This is to fix openfoodfacts/smooth-app#3118

auth.pl?body=1 --> returns a JSON body
auth.pl --> does not return a body

Plan:

  • update openfoodfacts-dart to call auth.pl?body=1 and expect a JSON body
  • deploy new Flutter app

Possibly:

  • wait until most instances of the apps have been updated
  • make sending a body the default for auth.pl

cc @M123-dev @monsieurtanuki

@stephanegigandet stephanegigandet added API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) 🔐 API auth The API requires auth in order to perform editing.There is a common mechanism & a Robotoff mechanism labels Oct 11, 2022
@stephanegigandet stephanegigandet requested a review from a team as a code owner October 11, 2022 07:43
@M123-dev
Copy link
Member

Looks good to me 👏🏼

teolemon
teolemon reviewed Oct 11, 2022
View reviewed changes
cgi/auth.pl Outdated Show resolved Hide resolved
@alexgarel @teolemon
docs: typo cgi/auth.pl
81de875 
Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@M123-dev M123-dev mentioned this pull request Oct 11, 2022
Merged
@stephanegigandet stephanegigandet merged commit 4c31673 into main Oct 11, 2022
@stephanegigandet stephanegigandet deleted the auth-body branch October 11, 2022 10:04
@alexgarel alexgarel mentioned this pull request Oct 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
🔐 API auth The API requires auth in order to perform editing.There is a common mechanism & a Robotoff mechanism API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…)
Projects
Revamping auth across Open Food Facts
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

This test fails, which prevents me from seeing if the resign of the app for iOS was successful
4 participants
@stephanegigandet @M123-dev @teolemon @alexgarel