Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW DESIGN - The action menu should be on the left of the Open Food Facts logo when scrolling #7497

Open
1 task
Tracked by #7295
teolemon opened this issue Oct 11, 2022 · 5 comments
Open
1 task
Tracked by #7295
Labels
CSS good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. 🎨 New design Issues related to the Open Food Facts JS/CSS/HTML redesign. ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. top navigation

Comments

@teolemon
Copy link
Member

What

  • The action menu should be on the left of the Open Food Facts logo when scrolling

Screenshot

image
image

Part of

@teolemon teolemon added 🐛 bug This is a bug, not a feature request. top navigation 🎨 New design Issues related to the Open Food Facts JS/CSS/HTML redesign. labels Oct 11, 2022
@teolemon teolemon added good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. CSS labels Oct 11, 2022
@stephanegigandet
Copy link
Contributor

Adding a logo when scrolling and thus moving the OFF logo to the right when scrolling would look quite weird IMHO.

@teolemon
Copy link
Member Author

Honestly, I could see it there all the time
image
image

@stephanegigandet
Copy link
Contributor

We could revisit what we put in our 2 top bars and which one(s) we keep when we scroll, but it's a broader design decision I think.

The Discourse demo has the menu on the other side than your screenshot. Those things keep moving. :)

image

@stephanegigandet
Copy link
Contributor

I think we should remove the good first issue etc. labels (and maybe rename the issue), this is probably not something we want people to work on until we have defined exactly what we want.

Copy link
Contributor

This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Dec 30, 2023
@teolemon teolemon moved this to To discuss and validate in 🍊 Open Food Facts Server issues Apr 23, 2024
@teolemon teolemon removed the 🐛 bug This is a bug, not a feature request. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. 🎨 New design Issues related to the Open Food Facts JS/CSS/HTML redesign. ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. top navigation
Projects
Status: To discuss and validate
Development

No branches or pull requests

2 participants