Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Knowledge panel card metaphor for the average nutrition facts on the category facet #7558

Open
Tracked by #3824
teolemon opened this issue Oct 15, 2022 · 3 comments
Labels
categories facets facets allow you to explore products according to various criterion. Based on MongoDB good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. 📖 Knowledge Panels - For facets 🎨 Mockup required 🎨 New design Issues related to the Open Food Facts JS/CSS/HTML redesign. P2 ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.

Comments

@teolemon
Copy link
Member

teolemon commented Oct 15, 2022

What

  • The category facets looks weird, with generated knowledge content not being in a card, and above the ranking system
  • Average Nutrition facts should be hierarchically below the Title page

Why

  • Coherence

Screenshot

image

Part of

@teolemon teolemon added facets facets allow you to explore products according to various criterion. Based on MongoDB categories ♞ Epic An epic groups several tasks/issues. It should have a meaning for users. labels Oct 15, 2022
@stephanegigandet stephanegigandet added the 🎨 New design Issues related to the Open Food Facts JS/CSS/HTML redesign. label Oct 18, 2022
@teolemon teolemon changed the title The category facets looks weird Use the Knowledge panel card metaphor for the average nutrition facts on the category facet Dec 4, 2022
@teolemon teolemon added good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. 🎨 Mockup required labels Dec 4, 2022
Copy link
Contributor

This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Dec 28, 2023
@mike-lu1
Copy link
Contributor

Hey @stephanegigandet this issue will strongly help me familiarize with the interface of OpenFoodFacts systemkindly assign it to me

@stephanegigandet
Copy link
Contributor

Hi @mike-lu1 , we don't assign issues, but you can work on it, nobody else is working on this.

Related code is the display_tag function of Display.pm, and we would need instead to create a knowledge panel for the nutrition table, and have the new code in KnowledgePanelsTags.pm

It's not a trivial issue though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categories facets facets allow you to explore products according to various criterion. Based on MongoDB good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. 📖 Knowledge Panels - For facets 🎨 Mockup required 🎨 New design Issues related to the Open Food Facts JS/CSS/HTML redesign. P2 ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.
Projects
Status: 🆕 New
Status: To discuss and validate
Status: Todo
Development

No branches or pull requests

3 participants