Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: add descriptions and comments as taxonomy fields #7628

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

raphael0202
Copy link
Contributor

What

Add description and comment as taxonomy fields.This way, we can display category description (and optional comments about tricky classification decisions about this category) in Hunger Games.
Category description could be used to on mobile apps and on web.

I only converted comments to taxonomy fields, other descriptions/comments can be added later.

@github-actions github-actions bot added categories 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels Oct 28, 2022
@raphael0202 raphael0202 force-pushed the add-description-comment branch from 7908ded to a76f07a Compare October 28, 2022 13:59
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@teolemon
Copy link
Member

@aleene is that ok with you as well ?

@aleene
Copy link
Contributor

aleene commented Oct 31, 2022

Ok for me

@teolemon
Copy link
Member

Thank you @raphael0202, merging

@teolemon teolemon merged commit f56beaf into main Oct 31, 2022
@teolemon teolemon deleted the add-description-comment branch October 31, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categories 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants