Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxonomize stores - Add autosuggest for stores #7632

Open
Tracked by #8865 ...
teolemon opened this issue Oct 29, 2022 · 12 comments · May be fixed by #9607
Open
Tracked by #8865 ...

Taxonomize stores - Add autosuggest for stores #7632

teolemon opened this issue Oct 29, 2022 · 12 comments · May be fixed by #9607
Labels
✏️ Editing - Auto Suggest Providing autosuggest for taxonomized fields. Mostly used in editing scenarii 🤳🥫 mobile apps P2 🏪 Stores

Comments

@teolemon
Copy link
Member

teolemon commented Oct 29, 2022

What

  • Add autosuggest for stores

Why

  • For the mobile app
  • To be able to provide availability by store

Code pointers

Part of

@teolemon teolemon added ✏️ Editing - Auto Suggest Providing autosuggest for taxonomized fields. Mostly used in editing scenarii 🏪 Stores labels Oct 29, 2022
@teolemon teolemon changed the title Add autosuggest for stores Taxonomize stores - Add autosuggest for stores Aug 16, 2023
@CloCkWeRX
Copy link
Contributor

#2011 is heavily related.

Openstreetmap has https://nsi.guide and ~904 supermarket https://nsi.guide/index.html?t=brands&k=shop&v=supermarket brands.

Use case 1:
Store names

Use case 2:
Store brands

@teolemon
Copy link
Member Author

teolemon commented Dec 3, 2023

Raphael O is working on that for Open Prices
openfoodfacts/open-prices#38
https://prices.openfoodfacts.org/docs
It might be interesting to pool the endpoint with Product Opener
@raphael0202

@CloCkWeRX
Copy link
Contributor

Looking at the stores.txt taxinomy, how much does it have to stay in that format?

vs say
https://raw.githubusercontent.com/osmlab/name-suggestion-index/main/data/brands/shop/supermarket.json

@CloCkWeRX CloCkWeRX linked a pull request Dec 31, 2023 that will close this issue
5 tasks
@aleene
Copy link
Contributor

aleene commented Dec 31, 2023

Better to keep the same format as the other taxonomies.

@CloCkWeRX
Copy link
Contributor

Hmm, may have been superceded by https://github.com/openfoodfacts/taxonomy-editor to a degree

@alexgarel
Copy link
Member

https://github.com/openfoodfacts/taxonomy-editor can help maintain the taxonomy, but for now we keep a format. But it's a good reason to keep same format.

Per se, the autosuggest could be instead provided by https://github.com/openfoodfacts/search-a-licious and maybe it's already in the @raphael0202 ?

@CloCkWeRX
Copy link
Contributor

Well, for the short term I've generated it in the taxinomy format in git:
#9607

Trivial to adjust the generation script to something else.

@raphael0202
Copy link
Contributor

@alexgarel No it's not included in search-a-licious, it looks like we have an "unofficial" store taxonomy though: https://world.openfoodfacts.org/data/taxonomies/stores.full.json

@CloCkWeRX
Copy link
Contributor

What's the preference re format - /data/taxonomies/stores.full.json or stores.txt.

Happy to enhance either as per #9607

@raphodn
Copy link
Member

raphodn commented Jan 27, 2024

Interesting for https://github.com/openfoodfacts/open-prices !

We're slowly getting dozens of stores with OFF products : https://prices.openfoodfacts.org/app/locations

@teolemon
Copy link
Member Author

@raphodn @raphael0202 @CloCkWeRX Please add a 👍 to the issue, so that it gets into popular issues

@CloCkWeRX
Copy link
Contributor

@teolemon - I'd be keen on PR feedback instead.
#9607 - if it's the wrong approach, okay, what's the right one these days?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editing - Auto Suggest Providing autosuggest for taxonomized fields. Mostly used in editing scenarii 🤳🥫 mobile apps P2 🏪 Stores
Projects
Status: To discuss and validate
Development

Successfully merging a pull request may close this issue.

6 participants