-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Editing packaging components on web site #7755
Conversation
…cts-server into packagings-edit
Hi @alexgarel and @raphael0202 , thanks a lot for the tests, review and suggestions. I believe I addressed all the points you raised. The new version is currently live on .dev : https://world-fr.openfoodfacts.dev/cgi/product.pl?type=edit&code=7771608000022 |
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, it works fine.
There is something we should however improve in the future:
The text field should be either erased, or regenerated after packaging update.
Currently if I remove a row in packaging (say tap) but do not pay attention and the element is present in text (1 tap), it won't be removed, and this really is counter intuitive to users.
Regenerating text comes with the advantage that it gives a clear template and is easy to modify. But the drawback is losing original input.
The text often contains the text of the recycling instructions on the package. I would prefer to keep it. |
A simple table in the product edit form in order to enter packaging components information.
Mobile:
It's not very user friendly, but it's a first step in order to be able to enter some data.
Also added new tags to the misc facet so that we can track packaging data:
Will be done later in separate PRs: