Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Data quality issues related to energy #7774

Merged
merged 1 commit into from
Nov 30, 2022
Merged

fix: Data quality issues related to energy #7774

merged 1 commit into from
Nov 30, 2022

Conversation

CharlesNepote
Copy link
Member

What

  • Increase detection percentage for en:energy-value-in-$unit-does-not-match-value-computed-from-other-nutrients, to avoird many false positive (10% -> 30%)
  • Create a data quality warning for products upper than 15%
  • Better comments

Related issue(s) and discussion

@CharlesNepote
Data quality issues related to energy
c4206cc 
* Increase detection percentage for en:energy-value-in-$unit-does-not-match-value-computed-from-other-nutrients (10% -> 30%)
* Create a data quality warning for products upper than 15%
* Better comments
@CharlesNepote CharlesNepote requested a review from a team as a code owner November 30, 2022 11:33
@github-actions github-actions bot added the 🧽 Data quality https://wiki.openfoodfacts.org/Quality label Nov 30, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stephanegigandet stephanegigandet merged commit d747479 into main Nov 30, 2022
@stephanegigandet stephanegigandet deleted the CharlesNepote-patch-2 branch November 30, 2022 12:08
@alexgarel alexgarel mentioned this pull request Nov 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@CharlesNepote CharlesNepote

Labels
🧽 Data quality https://wiki.openfoodfacts.org/Quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CharlesNepote @stephanegigandet