Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Small improvements to packaging edition #7788

Merged
merged 8 commits into from
Dec 6, 2022
Merged

fix: Small improvements to packaging edition #7788

merged 8 commits into from
Dec 6, 2022

Conversation

stephanegigandet
Copy link
Contributor

  • Accept commas in numbers (e.g. weight of packaging item entered on the web site) + tests
  • Add new packaging fields to knowledge panel

image

@stephanegigandet stephanegigandet requested a review from a team as a code owner December 2, 2022 15:51
@github-actions github-actions bot added API v3 API WRITE WRITE API to allow sending product info and image 🌱 Green-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🧪 tests labels Dec 2, 2022
@stephanegigandet stephanegigandet changed the title Small improvements to packaging edition fix: Small improvements to packaging edition Dec 2, 2022
alexgarel
alexgarel approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teolemon
Copy link
Member

teolemon commented Dec 3, 2022 •
edited
Loading

After this one, Can we merge the PR to add an action to this panel ?

@teolemon
Copy link
Member

teolemon commented Dec 5, 2022

I assume that this kind of issues (mismatch between what's saved and displayed) might be solved ? @stephanegigandet
image

image

https://world.openfoodfacts.org/cgi/product.pl?type=edit&code=3257980017970

@github-actions github-actions bot added 🧪 additives 🥜 Allergens API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) 🧪 integration tests 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧬 Taxonomies - Rebuild Taxonomies are compiled before they can be used. labels Dec 6, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stephanegigandet stephanegigandet merged commit df30876 into main Dec 6, 2022
@stephanegigandet stephanegigandet deleted the packagings-edit-2 branch December 6, 2022 17:57
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Dec 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon approved these changes

@alexgarel alexgarel alexgarel approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
🧪 additives 🥜 Allergens API v3 API WRITE WRITE API to allow sending product info and image API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) 🌱 Green-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products 🧪 integration tests 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🧬 Taxonomies - Rebuild Taxonomies are compiled before they can be used. 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🧪 tests
Projects
📦 Packaging improvements
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephanegigandet @teolemon @alexgarel