taxonomy: Pl ingredients

[moon-rabbitOFF]

No description provided.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[stephanegigandet]

There is a new mechanism to handle things like "dried something", we should not add them to the ingredients taxonomy, and instead we can enrich the ingredients_processing.txt taxonomy to add translations of "dried" etc. in other languages.

[benbenben2]

@stephanegigandet

@moon-rabbitOFF is right, it does not work for all languages. Polish, for example: https://pl.openfoodfacts.org/cgi/test_ingredients_analysis.pl?ingredients_text=liofilizowane+ananasy&type=add&action=process&submit=Envoyer

@moon-rabbitOFF, you have to edit the file lib/ProductOpener/ingredients.pm.
Under the comment
# English, French etc. match before or after the ingredient, require a space
you add a new line:
or ($product_lc eq 'pl')

That can be tackled in a different pull request (you will have merge conflict if you do it from this actual branch).

For this current pull request, make sure you keep only ingredients in this ingredients.txt file and processing method in ingredients_processing.txt and that should be fine.

[benbenben2]

@stephanegigandet, please review the last changes

Thank you @Teiron for your pull request related to this one

[codecov-commenter]

Codecov Report

Merging #7791 (58638d0) into main (e0f97b6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #7791   +/-   ##
=======================================
  Coverage   48.16%   48.16%           
=======================================
  Files         109      109           
  Lines       21015    21015           
  Branches     4739     4739           
=======================================
  Hits        10122    10122           
  Misses       9618     9618           
  Partials     1275     1275           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[stephanegigandet]

If everything is commented out, we need to remove the <en:sunflower seed on top

[benbenben2]

<en:sunflower seed
is now commented as well (not removed, if future contributor see it commented that will be a hint to understand that they are handled using processing taxonomy. Whereas if we remove the whole block there is risk that a future contributor add it in the taxonomy (although it should be noticed during code review))

[stephanegigandet]

ah ok my bad, I didn't look correctly

[stephanegigandet]

Looks good, thank you!

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information