Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation test should fail on missing placeholders #7906

Closed
teolemon opened this issue Dec 25, 2022 · 0 comments · Fixed by #7960
Closed

Translation test should fail on missing placeholders #7906

teolemon opened this issue Dec 25, 2022 · 0 comments · Fixed by #7960
Assignees
@diivi
Labels
🐛 bug This is a bug, not a feature request. ⭐ 🐛 top bug Top bug. Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org

Comments

@teolemon
Copy link
Member

teolemon commented Dec 25, 2022 •
edited
Loading

What

Translation test should fail on missing placeholders

# keep %s, it will be replaced by the letter A, B, C, D or E
msgctxt "attribute_nutriscore_grade_title"
msgid "Nutri-Score %s"
msgstr ""
msgstr "영양 점수"

To Reproduce

Visible in Korean translations

Expected behavior

Test fails, preventing faulty translations from making it to production
@teolemon teolemon added 🐛 bug This is a bug, not a feature request. Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org labels Dec 25, 2022
@github-actions github-actions bot added the ⭐ 🐛 top bug Top bug. label Jan 5, 2023
@github-actions github-actions bot mentioned this issue Jan 5, 2023
Open
@diivi diivi mentioned this issue Jan 7, 2023
Merged
@diivi diivi self-assigned this Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diivi diivi

Labels
🐛 bug This is a bug, not a feature request. ⭐ 🐛 top bug Top bug. Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add placeholder count check to check-translations.sh openfoodfacts/openfoodfacts-server
2 participants
@teolemon @diivi