Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: quality check when we have erythritol without polyols #7946

Merged
merged 4 commits into from
Jan 5, 2023
Merged

fix: quality check when we have erythritol without polyols #7946

merged 4 commits into from
Jan 5, 2023

Conversation

stephanegigandet
Copy link
Contributor

This fixes an issue when erythritol is set, but polyols is not set.

@stephanegigandet stephanegigandet requested a review from a team as a code owner January 5, 2023 10:36
@github-actions github-actions bot added 🧽 Data quality https://wiki.openfoodfacts.org/Quality Food.pm 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests labels Jan 5, 2023
@github-actions github-actions bot removed Food.pm 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels Jan 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

CharlesNepote
CharlesNepote approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@CharlesNepote CharlesNepote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stephanegigandet stephanegigandet merged commit ef47e9d into main Jan 5, 2023
@stephanegigandet stephanegigandet deleted the erythritol branch January 5, 2023 14:42
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Jan 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesNepote CharlesNepote CharlesNepote approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
🧽 Data quality https://wiki.openfoodfacts.org/Quality 🧪 tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephanegigandet @CharlesNepote