fix: parsing of dots in packagins / recycling instructions #7948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📦 Packaging
|
Kudos, SonarCloud Quality Gate passed!
|
|
Another one is "Barquette et film plastique à recycler" which from memory is not parsed properly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix for an issue reported on Slack by Mathieu Morey: " the text extraction got it really wrong: "Film plastique à jeter. Étui carton à recycler." adds a plastic sleeve (ok) that is marked recyclable (nope).
If I fix it and change the sleeve as "discard", another plastic sleeve that is recyclable is added..."
Also added more tests.