-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taxonomy: add new 2022 infotri system #7995
Conversation
Kudos, SonarCloud Quality Gate passed! |
taxonomies/packaging_recycling.txt
Outdated
@@ -32,14 +32,14 @@ pt:reutilizar, a reutilizar, para reutilizar, para ser reutilizado, a ser reutil | |||
en:recycle, to recycle, to be recycled, recyclable | |||
bg:за рециклиране, рециклирай, да се рециклира | |||
de:recyceln, zum Recyceln, recycelbar | |||
fr:recycler, à recycler, recyclable | |||
fr:bac de tri, recycler, à recycler, recyclable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a new child entry, "en:recycle in sorting bin, sorting bin"
taxonomies/packaging_recycling.txt
Outdated
hu:újrahasznosítható, újrahasznosítandó, újrahasznosításra | ||
pt:reciclável, a reciclar, para reciclar | ||
# associated_materials: en:glass, en:aluminium, en:steel | ||
|
||
<en:recycle | ||
en:recycle in glass bin, recycle in glass container, recycle with glass, in glass bin, in glass container | ||
fr:recycler dans le conteneur à verre, recycler dans le bac à verre, recycler avec le verre, dans le conteneur à verre, avec le verre | ||
fr:tri verre, bac verre, recycler dans le conteneur à verre, recycler dans le bac à verre, recycler avec le verre, dans le conteneur à verre, avec le verre |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is tricky. We probably should keep uniform names, starting with the action "recycler dans le conteneur à verre", the others can be added as synonyms. Then we can find ways to make suggestions work for synonyms, and maybe have short name properties if we need to display them in a specific way.
The suggestions from Stephane are applied in the last commit. |
according to suggestion Co-authored-by: Stéphane Gigandet <stephane@openfoodfacts.org>
Codecov Report
@@ Coverage Diff @@
## main #7995 +/- ##
==========================================
- Coverage 48.16% 48.14% -0.02%
==========================================
Files 109 109
Lines 21015 21008 -7
Branches 4739 4739
==========================================
- Hits 10122 10115 -7
Misses 9618 9618
Partials 1275 1275 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
What
taxonomy: add new 2022 infotri system