Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: add new 2022 infotri system #7995

Merged
merged 8 commits into from
Apr 17, 2023
Merged

Conversation

teolemon
Copy link
Member

What

taxonomy: add new 2022 infotri system

image

@teolemon teolemon added the 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling label Jan 16, 2023
@github-actions github-actions bot added the 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies label Jan 16, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@@ -32,14 +32,14 @@ pt:reutilizar, a reutilizar, para reutilizar, para ser reutilizado, a ser reutil
en:recycle, to recycle, to be recycled, recyclable
bg:за рециклиране, рециклирай, да се рециклира
de:recyceln, zum Recyceln, recycelbar
fr:recycler, à recycler, recyclable
fr:bac de tri, recycler, à recycler, recyclable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a new child entry, "en:recycle in sorting bin, sorting bin"

hu:újrahasznosítható, újrahasznosítandó, újrahasznosításra
pt:reciclável, a reciclar, para reciclar
# associated_materials: en:glass, en:aluminium, en:steel

<en:recycle
en:recycle in glass bin, recycle in glass container, recycle with glass, in glass bin, in glass container
fr:recycler dans le conteneur à verre, recycler dans le bac à verre, recycler avec le verre, dans le conteneur à verre, avec le verre
fr:tri verre, bac verre, recycler dans le conteneur à verre, recycler dans le bac à verre, recycler avec le verre, dans le conteneur à verre, avec le verre
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is tricky. We probably should keep uniform names, starting with the action "recycler dans le conteneur à verre", the others can be added as synonyms. Then we can find ways to make suggestions work for synonyms, and maybe have short name properties if we need to display them in a specific way.

@benbenben2
Copy link
Collaborator

@teolemon, @stephanegigandet

The suggestions from Stephane are applied in the last commit.
Please review the changes. Resolve conversations. And eventually approve and merge.

benbenben2 and others added 3 commits April 14, 2023 18:00
@benbenben2 benbenben2 requested a review from a team as a code owner April 14, 2023 19:24
@codecov-commenter
Copy link

Codecov Report

Merging #7995 (4a0a12c) into main (ec9ca2a) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 4a0a12c differs from pull request most recent head 9825731. Consider uploading reports for the commit 9825731 to get more accurate results

@@            Coverage Diff             @@
##             main    #7995      +/-   ##
==========================================
- Coverage   48.16%   48.14%   -0.02%     
==========================================
  Files         109      109              
  Lines       21015    21008       -7     
  Branches     4739     4739              
==========================================
- Hits        10122    10115       -7     
  Misses       9618     9618              
  Partials     1275     1275              

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephanegigandet stephanegigandet merged commit b2f9b1d into main Apr 17, 2023
@stephanegigandet stephanegigandet deleted the packaging-fixes branch April 17, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants