Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: logo for comcombre de france #7997

Merged
merged 3 commits into from
Jan 23, 2023
Merged

feat: logo for comcombre de france #7997

merged 3 commits into from
Jan 23, 2023

Conversation

teolemon
Copy link
Member

What

feat: logo for comcombre de france

@teolemon teolemon requested a review from a team as a code owner January 16, 2023 18:03
@stephanegigandet
Copy link
Contributor

If the height is not 90px, the logo won't be shown.

alexgarel
alexgarel requested changes Jan 20, 2023
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See stephane comment

alexgarel
alexgarel approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
image

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

stephanegigandet
stephanegigandet approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephanegigandet stephanegigandet merged commit 2bdc14d into main Jan 23, 2023
@stephanegigandet stephanegigandet deleted the concombre-de-france-logo branch January 23, 2023 08:52
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Jan 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@teolemon teolemon

Labels
None yet
Projects
old prs
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teolemon @stephanegigandet @alexgarel