-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrating openfoodfacts-server with codecov for unit test coverage #8016
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8016 +/- ##
=======================================
Coverage ? 44.35%
=======================================
Files ? 99
Lines ? 20330
Branches ? 4682
=======================================
Hits ? 9017
Misses ? 10241
Partials ? 1072 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing, maybe because you need to build taxonomies and be sure to rebuild languages.
I think if we add coverage it has to replace test (because really it's running tests) in pull_request.yml
Also if there is a way to avoid the cover progression, because it makes logs really hard to read… |
yes they look very annoying. let's see if I can do something about that |
d6d5269
to
108e6f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect ! Good work :-)
Let's start with this in parallel of normal tests, but I hope we will move fast to also have integration tests so that we can replace the main test run by this.
Kudos, SonarCloud Quality Gate passed! |
we can merge this now @alexgarel |
@yuktea if a PR is approved and checks are ok, feel free to merge it yourself 🙂 |
This PR has,
Devel::Cover
for generating a coverage report forProductOpener
.Devel::Cover::Report::Codecovbash
instead of the recommendedDevel::Cover::Report::Codecov
because instead of directly uploading to codecov,Devel::Cover::Report::Codecovbash
generates ajson
file first.