Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrating openfoodfacts-server with codecov for unit test coverage #8016

Merged
merged 20 commits into from
Jan 27, 2023

Conversation

yuktea
Copy link
Contributor

@yuktea yuktea commented Jan 20, 2023

This PR has,

  • Used CPAN::Devel::Cover for generating a coverage report for ProductOpener.
  • Used Devel::Cover::Report::Codecovbash instead of the recommended Devel::Cover::Report::Codecov because instead of directly uploading to codecov, Devel::Cover::Report::Codecovbash generates a json file first.

@yuktea yuktea requested a review from a team as a code owner January 20, 2023 10:04
@github-actions github-actions bot added the GitHub Actions Pull requests that update Github_actions code label Jan 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@43c74d6). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8016   +/-   ##
=======================================
  Coverage        ?   44.35%           
=======================================
  Files           ?       99           
  Lines           ?    20330           
  Branches        ?     4682           
=======================================
  Hits            ?     9017           
  Misses          ?    10241           
  Partials        ?     1072           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing, maybe because you need to build taxonomies and be sure to rebuild languages.

I think if we add coverage it has to replace test (because really it's running tests) in pull_request.yml

@alexgarel
Copy link
Member

Also if there is a way to avoid the cover progression, because it makes logs really hard to read…

@yuktea
Copy link
Contributor Author

yuktea commented Jan 24, 2023

Also if there is a way to avoid the cover progression, because it makes logs really hard to read…

yes they look very annoying. let's see if I can do something about that

@yuktea yuktea force-pushed the codecov-integration branch from d6d5269 to 108e6f5 Compare January 24, 2023 20:54
@yuktea yuktea requested a review from alexgarel January 25, 2023 14:49
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect ! Good work :-)

Let's start with this in parallel of normal tests, but I hope we will move fast to also have integration tests so that we can replace the main test run by this.

.github/workflows/codecov.yml Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yuktea yuktea added the CI Continuous integration label Jan 25, 2023
@yuktea
Copy link
Contributor Author

yuktea commented Jan 26, 2023

we can merge this now @alexgarel

@alexgarel alexgarel merged commit 984171a into main Jan 27, 2023
@alexgarel alexgarel deleted the codecov-integration branch January 27, 2023 10:45
@alexgarel
Copy link
Member

@yuktea if a PR is approved and checks are ok, feel free to merge it yourself 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration GitHub Actions Pull requests that update Github_actions code Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants