Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exclude nutrition id containing nutrition-score #8035

Merged
merged 1 commit into from
Jan 26, 2023
Merged

fix: exclude nutrition id containing nutrition-score #8035

merged 1 commit into from
Jan 26, 2023

Conversation

benbenben2
Copy link
Collaborator

excluding all nutriments containing "nutrition-score" (nutrition-score, nutrition-score-fr)

Tested that negative value is still working for common nutriment. But it is not possible to test negative nutrition-score itself because there are no examples in the test data and I do not know how to create such negative nutrition-score.

could fix #7988

@benbenben2 benbenben2 added 🧽 Data quality https://wiki.openfoodfacts.org/Quality Fixed ? This issue might have been fixed. We can close them once we verify that they have. 🧽 Data quality - Measure - Quality facets One of the facets available in Open Food Facts is /quality & allows us to spot products w/ bad data 🧽 Data quality - Nutrition labels Jan 25, 2023
@benbenben2 benbenben2 requested a review from a team as a code owner January 25, 2023 21:49
@benbenben2 benbenben2 self-assigned this Jan 25, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

alexgarel
alexgarel approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 thank you so much @benbenben2 !

@alexgarel alexgarel merged commit 3641834 into main Jan 26, 2023
@alexgarel alexgarel deleted the fix_add_data_quality_issue_for_negatives_values_in_nutrition_table_2 branch January 26, 2023 09:14
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Jan 26, 2023
Merged
@stephanegigandet
Copy link
Contributor

Thank you @benbenben2 !

@CharlesNepote
Copy link
Member

Thanks @benbenben2 !

@benbenben2 benbenben2 mentioned this pull request Jan 28, 2023
Merged
@CharlesNepote
Copy link
Member

@stephanegigandet is it possible to deploy it today as the number of this data quality error is increasing quickly:

As a result, data quality errors percentage is increasing while it was continuously decreasing since 2 months :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

@CharlesNepote CharlesNepote Awaiting requested review from CharlesNepote

@stephanegigandet stephanegigandet Awaiting requested review from stephanegigandet

Assignees

@benbenben2 benbenben2

Labels
🧽 Data quality - Measure - Quality facets One of the facets available in Open Food Facts is /quality & allows us to spot products w/ bad data 🧽 Data quality - Nutrition 🧽 Data quality https://wiki.openfoodfacts.org/Quality Fixed ? This issue might have been fixed. We can close them once we verify that they have.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benbenben2 @stephanegigandet @CharlesNepote @alexgarel