fix: Small changes for the GS1 import through Bayard #8037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanegigandet
added
the
🏭 Producers Platform
github-actions
bot
added
GS1
stephanegigandet
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
teolemon
reviewed
Jan 30, 2023
| @@ -3717,13 +3717,10 @@ country:en:Belgium | |||
| image:en:biogarantie-bel.90x90.svg | |||
|
|
|||
| <en:EU organic | |||
| en:EG-Öko-Verordnung | |||
There was a problem hiding this comment.
shouldn't we keep it ? It might break some external stuff
There was a problem hiding this comment.
It's covered by xx:EG-Öko-Verordnung, external tools may have to add support for xx: synonyms if they don't have it yet though.
teolemon
approved these changes
Jan 30, 2023
alexgarel
approved these changes
Jan 31, 2023
|
|
||
| # import CSV file | ||
|
|
||
| export PERL5LIB="/srv/off-pro/lib:${PERL5LIB}" |
There was a problem hiding this comment.
Picky: This means it won't work in docker. (not that important yet, but not future proof). If it's pattern already used in several place, we will fix it in the future.
There was a problem hiding this comment.
It's used in similar scripts for Equadis and Agena3000
teolemon
added
the
German
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for some German specific values. More to come.