-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New design on producers platform #8086
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8086 +/- ##
==========================================
+ Coverage 45.20% 45.36% +0.15%
==========================================
Files 102 102
Lines 20272 20206 -66
Branches 4639 4626 -13
==========================================
+ Hits 9164 9166 +2
+ Misses 10011 9943 -68
Partials 1097 1097
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I added some screenshots
- We should have the key actions inline as buttons (Import file…), otherwise the CTR is going to decrease
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool work.
I have some minor comments.
templates/web/common/includes/display_product_search_or_add_producer.tt.html
Outdated
Show resolved
Hide resolved
<div class="row"> | ||
<div class="small-12 column v-space-short"> | ||
<div class="panel"> | ||
<p>[% lang('account_without_org') %]</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want to also have a link to public platform here, for users that may get lost ?
<li><a href="/cgi/import_photos_upload.pl">[% lang('import_product_photos') %]</a></li> | ||
<li><a href="/cgi/export_products.pl">[% lang('export_product_data_photos') %]</a></li> | ||
<li><a href="/cgi/remove_products.pl">[% lang('remove_products_from_producers_platform') %]</a></li> | ||
<li class="divider"></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A much wanted feature by @manon-corneille is a link to the user guide. Could we add it here ? (but it should be translatable string as the link differs between french and others (english for now)).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. I added a link to the user guide.
…html Co-authored-by: Alex Garel <alex@garel.org>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR brings the new design to the producers platform.
Notable changes:
Also removed some dead code that was use in the old design (e.g. functions and templates used to generate blocks shown on the now defunct left sidebar).
Screenshots