-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taxonomy: add 🇩🇪 alias for Creme Fraiche without the accents #8144
taxonomy: add 🇩🇪 alias for Creme Fraiche without the accents #8144
Conversation
Kudos, SonarCloud Quality Gate passed!
|
The ingredient in the product that you linked is "Créme fraîche" (with some accents, and it is also an unknown ingredient). Hence, I would suggest to add also "Créme fraîche" among the synonyms. What do you think? |
The problem of "Créme fraîche" vs. "Creme Fraiche" is that it is hard to type the french version on a German keyboard. So yes, adding a synonym sounds good to me. How can i add it to the synonyms? |
"Créme fraîche" (as written on the package) is actually a mispelling (should be "Crème fraîche). It's not a good idea to add mispellings in the taxonomy (even if some of them can be found on products). Instead we can improve the parser to match some mispellings. For languages like German that use foreign words that are frequently listed / typed without accents, I think it's fine to add the unaccented version as a synonym as done in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Thanks for explaining the accent spelling mistake. I just checked the packaging from the same product which i have at home at the moment. It is fixed in the meantime. I need to update the picture soon. |
What
add 🇩🇪 alias for Creme Fraiche without the accents e.g. as seen in ingredient list of https://de.openfoodfacts.org/produkt/4008366009763/schlemmerfilet-brokkoli-mandel-frosta
Screenshot
Related issue(s) and discussion