-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taxonomy: issue 7312/7313/7314/7316 #8151
Conversation
Thank you @benbenben2! I completely lost track of those issues after planning to work on them; I'm glad the links were helpful. It's great that you've kept the distinction between Munster / Muenster cheese as well. No doubt some puzzlement over that in future, but it's real-world detail and I think that's important. |
@@ -39374,6 +39374,50 @@ fr:Fromages d’abbaye | |||
nl:Abdijkazen, Abdijkaas | |||
wikidata:en:Q2069008 | |||
|
|||
<en:Cheeses | |||
en:American cheese |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For categories, we put the plural as the first name in each language. "American cheeses".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been updated for the languages I know and removed for the others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you!
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@@ -39374,6 +39374,50 @@ fr:Fromages d’abbaye | |||
nl:Abdijkazen, Abdijkaas | |||
wikidata:en:Q2069008 | |||
|
|||
<en:Cheeses | |||
en:American cheese |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you!
Adding some cheese in ingredients.txt and categories.txt taxonomies.
These are related to issues created by @jayaddison a couple of month ago. I hope that it is fine to work on it.
Resolve #7312
Resolve #7313
Resolve #7314
Resolve #7316
1-#7313
Because a Havarti cheese is composed of couple of ingredients (milk, salt, etc.), Havarti cheese could be also added in categories.txt taxonomy.
For ingredients.txt,
we added Havarti in ingredients.txt
For categories.txt,
there is already an entry for Havarti cheese: https://world.openfoodfacts.org/category/havarti.
We added more languages for this category: https://www.wikidata.org/wiki/Q1591487
Remark: there are some product with Havarti as an ingredient: https://world.openfoodfacts.org/ingredient/Havarti
2- #7312
Because a Cotija cheese is composed of couple of ingredients (milk, salt, etc.), Cotija cheese could be also added in categories.txt taxonomy.
Additional information: https://www.wikidata.org/wiki/Q2718594
For ingredients.txt,
we added Cotija in ingredients.txt
For categories.txt,
we added Cotija in categories.txt
Remark: there are some product with Muenster as an ingredient: https://world.openfoodfacts.org/ingredient/cotija
3- #7316
Because a Muenster cheese is composed of couple of ingredients (milk, salt, etc.), Muenster cheese could be also added in categories.txt taxonomy.
For ingredients.txt,
we added languages to Munster in ingredients.txt: https://www.wikidata.org/wiki/Q765540
we added Muenster in ingredients.txt: https://www.wikidata.org/wiki/Q6931973
For categories.txt,
we added Munster in categories.txt
we added Muenster in categories.txt
Remark: there are some product with Muenster as an ingredient: https://world.openfoodfacts.org/ingredient/muenster
4- #7314
Because a Colby cheese is composed of couple of ingredients (milk, salt, etc.), Colby cheese could be also added in categories.txt taxonomy.
For ingredients.txt,
we added Colby in ingredients.txt
For categories.txt,
we added Colby in categories.txt
Remark: there are some product with Muenster as an ingredient: https://world.openfoodfacts.org/ingredient/Colby
Finally, thank you @jayaddison to have added links and comments in your issues, that was very helpful.