Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: issue 7312/7313/7314/7316 #8151

Merged
merged 5 commits into from
Mar 6, 2023

Conversation

benbenben2
Copy link
Collaborator

Adding some cheese in ingredients.txt and categories.txt taxonomies.

These are related to issues created by @jayaddison a couple of month ago. I hope that it is fine to work on it.

Resolve #7312
Resolve #7313
Resolve #7314
Resolve #7316

1-#7313
Because a Havarti cheese is composed of couple of ingredients (milk, salt, etc.), Havarti cheese could be also added in categories.txt taxonomy.
For ingredients.txt,
we added Havarti in ingredients.txt
For categories.txt,
there is already an entry for Havarti cheese: https://world.openfoodfacts.org/category/havarti.
We added more languages for this category: https://www.wikidata.org/wiki/Q1591487

Remark: there are some product with Havarti as an ingredient: https://world.openfoodfacts.org/ingredient/Havarti

2- #7312
Because a Cotija cheese is composed of couple of ingredients (milk, salt, etc.), Cotija cheese could be also added in categories.txt taxonomy.
Additional information: https://www.wikidata.org/wiki/Q2718594

For ingredients.txt,
we added Cotija in ingredients.txt
For categories.txt,
we added Cotija in categories.txt

Remark: there are some product with Muenster as an ingredient: https://world.openfoodfacts.org/ingredient/cotija

3- #7316
Because a Muenster cheese is composed of couple of ingredients (milk, salt, etc.), Muenster cheese could be also added in categories.txt taxonomy.

For ingredients.txt,
we added languages to Munster in ingredients.txt: https://www.wikidata.org/wiki/Q765540
we added Muenster in ingredients.txt: https://www.wikidata.org/wiki/Q6931973
For categories.txt,
we added Munster in categories.txt
we added Muenster in categories.txt

Remark: there are some product with Muenster as an ingredient: https://world.openfoodfacts.org/ingredient/muenster

4- #7314
Because a Colby cheese is composed of couple of ingredients (milk, salt, etc.), Colby cheese could be also added in categories.txt taxonomy.

For ingredients.txt,
we added Colby in ingredients.txt
For categories.txt,
we added Colby in categories.txt

Remark: there are some product with Muenster as an ingredient: https://world.openfoodfacts.org/ingredient/Colby

Finally, thank you @jayaddison to have added links and comments in your issues, that was very helpful.

@benbenben2 benbenben2 self-assigned this Feb 28, 2023
@github-actions github-actions bot added categories 🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels Feb 28, 2023
@jayaddison
Copy link
Contributor

Thank you @benbenben2! I completely lost track of those issues after planning to work on them; I'm glad the links were helpful.

It's great that you've kept the distinction between Munster / Muenster cheese as well. No doubt some puzzlement over that in future, but it's real-world detail and I think that's important.

@@ -39374,6 +39374,50 @@ fr:Fromages d’abbaye
nl:Abdijkazen, Abdijkaas
wikidata:en:Q2069008

<en:Cheeses
en:American cheese
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For categories, we put the plural as the first name in each language. "American cheeses".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been updated for the languages I know and removed for the others.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@@ -39374,6 +39374,50 @@ fr:Fromages d’abbaye
nl:Abdijkazen, Abdijkaas
wikidata:en:Q2069008

<en:Cheeses
en:American cheese
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@stephanegigandet stephanegigandet merged commit 1660e84 into main Mar 6, 2023
@stephanegigandet stephanegigandet deleted the taxonomy_jayaddison_issues branch March 6, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categories 🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
3 participants