Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Perl introductory resources to warm newbies about Perl #8204 #8206

Merged
merged 6 commits into from
Mar 20, 2023

Conversation

jnsereko
Copy link
Contributor

@jnsereko jnsereko commented Mar 14, 2023

@jnsereko jnsereko requested a review from a team as a code owner March 14, 2023 19:58
@github-actions github-actions bot added the 📚 Documentation Documentation issues improve the project for everyone. label Mar 14, 2023
@stephanegigandet
Copy link
Contributor

Hi @jnsereko

Thanks for the PR!

I think it would be better to create a new document how-to-learn-perl.md , and link it from how-to-quick-start-guide.md

cc @alexgarel

Copy link
Contributor Author

@jnsereko jnsereko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do you find this @yuktea @stephanegigandet? Any objections to adding a note?

@yuktea
Copy link
Contributor

yuktea commented Mar 15, 2023

looks cool!

@stephanegigandet
Copy link
Contributor

how do you find this @yuktea @stephanegigandet? Any objections to adding a note?

Looks good, could you also add a link to it in how-to-quick-start-guide.md ?

Update docs/dev/how-to-learn-perl.md

Co-authored-by: VaiTon <eyadlorenzo@gmail.com>

add learn perl link to readme
@jnsereko
Copy link
Contributor Author

i have pushed some commit @yuktea @stephanegigandet
kindly review

docs/dev/how-to-quick-start-guide.md Outdated Show resolved Hide resolved
docs/dev/how-to-use-repl.md Outdated Show resolved Hide resolved
docs/dev/how-to-learn-perl.md Show resolved Hide resolved
docs/dev/how-to-learn-perl.md Outdated Show resolved Hide resolved
docs/dev/how-to-learn-perl.md Outdated Show resolved Hide resolved
jnsereko and others added 4 commits March 19, 2023 12:38
Co-authored-by: VaiTon <eyadlorenzo@gmail.com>
Co-authored-by: VaiTon <eyadlorenzo@gmail.com>
Co-authored-by: VaiTon <eyadlorenzo@gmail.com>
Co-authored-by: VaiTon <eyadlorenzo@gmail.com>
Copy link
Contributor

@yuktea yuktea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes, looks good.

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jnsereko !

Co-authored-by: VaiTon <eyadlorenzo@gmail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexgarel alexgarel merged commit bda3722 into openfoodfacts:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 Documentation Documentation issues improve the project for everyone.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Perl introductory resources to warm newbies about Perl
5 participants