fix: support for accented language less taxonomy entries + images #8218

stephanegigandet · 2023-03-16T11:59:56Z

Fixes #8212
Fixes #8217

This PR:

makes the "wildcard language" xx: an unaccented language.
solves the issue of images for accented taxonomy entries
adds tests

alexgarel

Perfect !

(ok 90% perfect, as you didn't add tests on get_tag_image 😉 )

alexgarel · 2023-03-16T13:06:35Z

lib/ProductOpener/Tags.pm

+	# Add a version string to the taxonomy data
+	# Change this version string if you want to force the taxonomies to be rebuilt
+	# e.g. if the taxonomy building algorithm or configuration has changed
+	# This needs to be done also when the unaccenting parameters for languages set in Config.pm are changed
+
+	$sha1->add("20230316 - made xx: unaccented");


Very good idea :-)

stephanegigandet · 2023-03-16T13:23:54Z

(ok 90% perfect, as you didn't add tests on get_tag_image wink )

@alexgarel Actually there are 2, and one of them is failing... :-(

# Tags images
is(get_tag_image("en", "labels", "usda-organic"), "/images/lang/en/labels/usda-organic.90x90.svg");
is(get_tag_image("sv", "labels", "sv:ä-märket"), "/images/lang/sv/labels/ä-märket.141x90.png");

codecov-commenter · 2023-03-16T14:21:51Z

Codecov Report

Merging #8218 (f342d91) into main (65f8415) will increase coverage by 0.06%.
The diff coverage is 97.05%.

@@            Coverage Diff             @@
##             main    #8218      +/-   ##
==========================================
+ Coverage   46.99%   47.06%   +0.06%     
==========================================
  Files         104      104              
  Lines       20437    20448      +11     
  Branches     4650     4650              
==========================================
+ Hits         9604     9623      +19     
+ Misses       9684     9678       -6     
+ Partials     1149     1147       -2