Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not show the lilo prompt in countries where it's unsupported #8236

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

jnsereko
Copy link
Contributor

@jnsereko jnsereko commented Mar 20, 2023

What

Do not show the lilo prompt in countries where it's unsupported
https://www.lilo.org/fr/open-food-facts/

Screenshot

Screen.Recording.2023-03-21.at.00.37.43.mov

cc @yuktea @stephanegigandet @alexgarel

Related issue(s) and discussion

  • Fixes #[7905]

@jnsereko jnsereko requested a review from a team as a code owner March 20, 2023 21:34
@github-actions github-actions bot added Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 👥 Users labels Mar 20, 2023
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@@ -4,7 +4,9 @@

[% IF !server_options_producers_platform %]
<h3>[% lang('you_can_also_help_us') %]</h3>
Copy link
Contributor

@stephanegigandet stephanegigandet Mar 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jnsereko!

Could you include this <h3> title inside the IF below? Otherwise we show "Help us to fund the OFF project" but with nothing under it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @stephanegigandet
i have added the <h3> into the if, but i didn't like below but i didn't understand pretty well what you meant with "Otherwise we show "Help us to fund the OFF project" but with nothing under it."

    [% IF lc == "en" or lc == "fr" %]
        <h3>[% lang('you_can_also_help_us') %]</h3>
        <p>[% lang('bottom_content') %]</p>
    [% END %]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant that the h3 tag goes with the p tag, if we don't display the p tag, then we don't want to display just a h3 title with nothing under it.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephanegigandet stephanegigandet merged commit fd4ee43 into openfoodfacts:main Mar 23, 2023
@yuktea
Copy link
Contributor

yuktea commented Mar 23, 2023

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 👥 Users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not show the lilo prompt in countries where it's unsupported
3 participants