-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Do not show the lilo prompt in countries where it's unsupported #8236
Conversation
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
@@ -4,7 +4,9 @@ | |||
|
|||
[% IF !server_options_producers_platform %] | |||
<h3>[% lang('you_can_also_help_us') %]</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @jnsereko!
Could you include this <h3>
title inside the IF below? Otherwise we show "Help us to fund the OFF project" but with nothing under it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @stephanegigandet
i have added the <h3>
into the if, but i didn't like below but i didn't understand pretty well what you meant with "Otherwise we show "Help us to fund the OFF project" but with nothing under it."
[% IF lc == "en" or lc == "fr" %]
<h3>[% lang('you_can_also_help_us') %]</h3>
<p>[% lang('bottom_content') %]</p>
[% END %]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant that the h3 tag goes with the p tag, if we don't display the p tag, then we don't want to display just a h3 title with nothing under it.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Thanks for the PR! |
What
Do not show the lilo prompt in countries where it's unsupported
https://www.lilo.org/fr/open-food-facts/
Screenshot
Screen.Recording.2023-03-21.at.00.37.43.mov
cc @yuktea @stephanegigandet @alexgarel
Related issue(s) and discussion