fix: refactor protection of data imported from producers #8274
Conversation
stephanegigandet
changed the title
|
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
Codecov Report
@@ Coverage Diff @@
## main #8274 +/- ##
==========================================
- Coverage 46.61% 46.60% -0.01%
==========================================
Files 106 106
Lines 20787 20797 +10
Branches 4696 4699 +3
==========================================
+ Hits 9689 9692 +3
- Misses 9946 9953 +7
Partials 1152 1152
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Really cool implementation.
I have some comments. The most important being about the 1 year rule.
Also it would be great if we could act on the web form (and the mobile form) to avoid users to try to modify those fields if they can't ! I see a lot of complaints coming.
| method => 'GET', | ||
| path => '/api/v2/product/0200000000135', | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
You did not test,if it works for moderators on protected products.
There was a problem hiding this comment.
@alexgarel I added some tests for moderators.
Co-authored-by: Alex Garel <alex@garel.org>
Co-authored-by: Alex Garel <alex@garel.org>
Co-authored-by: Alex Garel <alex@garel.org>
| @@ -2145,24 +2149,24 @@ | |||
| "ingredients" : [ | |||
| { | |||
| "id" : "es:apple", | |||
| "percent_estimate" : 66.6666666666667, | |||
| "percent_estimate" : "66.6666666666667", | |||
There was a problem hiding this comment.
Strange that strings strikes back
|
Kudos, SonarCloud Quality Gate passed!
|
This PR solves some issues from #6816