-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taxonomy: ro translations #8290
Conversation
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
Codecov Report
@@ Coverage Diff @@
## main #8290 +/- ##
=======================================
Coverage 48.16% 48.16%
=======================================
Files 109 109
Lines 21015 21015
Branches 4739 4739
=======================================
Hits 10122 10122
Misses 9618 9618
Partials 1275 1275 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
taxonomies/ingredients.txt
Outdated
@@ -14353,6 +14353,7 @@ nn:ghi, ghee | |||
pa:ਘਿਉ | |||
pl:ghi, ghee | |||
pt:ghi, ghee | |||
ro:ulei de unt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think that we could add "ghee" as a synonym as well?
ro:ulei de unt | |
ro:ulei de unt, ghee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rather keep them separate, just to keep the indian variant as its own entity. You could add it to butter fat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexgarel,
I understood that @aleene suggests to keep only ghee in this block (indian variant) and add ulei de unt in other entry (butter fat)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion from @aleene has been applied (you can ignore the first comment of this thread)
@benbenben2 and @aleene would you approve ? |
@alexgarel , @moon-rabbitOFF , @aleene As suggested by @aleene, "ulei de unt" was move under "en:butterfat" (which already contains "butter oil" ("ulei de unt" in English) as synonym). And the other block where "ulei de unt" was located, now contains only "ghee" for all languages. |
Thank you for your modifications @benbenben2 |
Kudos, SonarCloud Quality Gate passed! |
What
🤖 Generated by Copilot at d440efb
Summary
Walkthrough
Part of