Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: ro translations #8290

Merged
merged 7 commits into from
May 2, 2023
Merged

taxonomy: ro translations #8290

merged 7 commits into from
May 2, 2023

Conversation

moon-rabbitOFF
Copy link
Contributor

@moon-rabbitOFF moon-rabbitOFF commented Apr 5, 2023

What

🤖 Generated by Copilot at d440efb

Summary

Walkthrough

Part of

@github-actions github-actions bot added 🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels Apr 5, 2023
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2023

Codecov Report

Merging #8290 (d440efb) into main (e0f97b6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8290   +/-   ##
=======================================
  Coverage   48.16%   48.16%           
=======================================
  Files         109      109           
  Lines       21015    21015           
  Branches     4739     4739           
=======================================
  Hits        10122    10122           
  Misses       9618     9618           
  Partials     1275     1275           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stephanegigandet stephanegigandet changed the title ro translations taxonomy: ro translations Apr 7, 2023
@@ -14353,6 +14353,7 @@ nn:ghi, ghee
pa:ਘਿਉ
pl:ghi, ghee
pt:ghi, ghee
ro:ulei de unt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think that we could add "ghee" as a synonym as well?

Suggested change
ro:ulei de unt
ro:ulei de unt, ghee

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rather keep them separate, just to keep the indian variant as its own entity. You could add it to butter fat.

Copy link
Collaborator

@benbenben2 benbenben2 Apr 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexgarel,
I understood that @aleene suggests to keep only ghee in this block (indian variant) and add ulei de unt in other entry (butter fat)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion from @aleene has been applied (you can ignore the first comment of this thread)

@alexgarel
Copy link
Member

@benbenben2 and @aleene would you approve ?

@benbenben2
Copy link
Collaborator

@alexgarel , @moon-rabbitOFF , @aleene

As suggested by @aleene, "ulei de unt" was move under "en:butterfat" (which already contains "butter oil" ("ulei de unt" in English) as synonym).

And the other block where "ulei de unt" was located, now contains only "ghee" for all languages.

@moon-rabbitOFF
Copy link
Contributor Author

moon-rabbitOFF commented Apr 25, 2023

Thank you for your modifications @benbenben2

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@benbenben2 benbenben2 merged commit 8f55d1f into main May 2, 2023
@benbenben2 benbenben2 deleted the ro-translations branch May 2, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants