Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix routing pages #8305

Merged
merged 4 commits into from
Apr 11, 2023
Merged

fix: Fix routing pages #8305

merged 4 commits into from
Apr 11, 2023

Conversation

stephanegigandet
Copy link
Contributor

Fixes issue #8304

Also adds a few tests, but we should clearly add tests for all possible route types.

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2023

Codecov Report

Merging #8305 (e3f2ff3) into main (acfb092) will increase coverage by 0.01%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main    #8305      +/-   ##
==========================================
+ Coverage   47.05%   47.06%   +0.01%     
==========================================
  Files         109      109              
  Lines       20992    20991       -1     
  Branches     4737     4739       +2     
==========================================
+ Hits         9878     9880       +2     
+ Misses       9947     9942       -5     
- Partials     1167     1169       +2     
Impacted Files Coverage Δ
tests/unit/routing.t 91.66% <85.71%> (-8.34%) ⬇️
lib/ProductOpener/Routing.pm 30.10% <100.00%> (+2.53%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stephanegigandet stephanegigandet merged commit 1991f33 into main Apr 11, 2023
@stephanegigandet stephanegigandet deleted the fix-routing-pages branch April 11, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants