-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: gzip all JSON OCRs when saving OCR file on disk #8320
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8320 +/- ##
==========================================
+ Coverage 48.46% 48.50% +0.03%
==========================================
Files 114 114
Lines 21268 21295 +27
Branches 4768 4773 +5
==========================================
+ Hits 10308 10329 +21
- Misses 9677 9679 +2
- Partials 1283 1287 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@raphael0202 broken test: (tests/unit/send_image_to_cloud_vision.t) To run locally :
|
@alexgarel I haven't set up Product Opener locally, will give it a try ;) |
5aa1d75
to
638852b
Compare
- gzip all JSON OCRs when saving OCR file on disk - add new `created_at` field to save the timestamp of OCR generation
638852b
to
2bfb407
Compare
Kudos, SonarCloud Quality Gate passed! |
@alexgarel it should be good now! |
I checked locally, the generated gzipped JSON file saved correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great @raphael0202 !
To save space, all OCR files were gzipped, but new generated files are still saved as plain text JSON files.
Also add a
created_at
field in the OCR JSON file containing the timestamp of generation of the OCR file. This is useful to know if we should generate again old OCR files.