Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_all_products.pl should also update obsolete products collection #8328

Open
Tracked by #8814
alexgarel opened this issue Apr 17, 2023 · 4 comments
Open
Tracked by #8814
Labels
🗄 Obsolete products ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.

Comments

@alexgarel
Copy link
Member

alexgarel commented Apr 17, 2023

Describe the bug

We moved obsolete products to their collections on #8277

But update_all_products is only processing the main collection. As this is used for structure migration this might leads to inconsistencies.

To Reproduce

see update_all_products.pl

Expected behavior

should process both collections.

Type of device

Browser

Part of

@alexgarel alexgarel added the 🐛 bug This is a bug, not a feature request. label Apr 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

This issue is stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Aug 1, 2023
@alexgarel
Copy link
Member Author

@stephanegigandet will it be fixed by #8811 ?

@github-actions github-actions bot removed the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Aug 9, 2023
@stephanegigandet
Copy link
Contributor

@alexgarel yes, #8811 adds the possibility to choose to run the update on obsolete products (it's not the default though)

Copy link
Contributor

This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts

@github-actions github-actions bot added the Stale label Nov 13, 2023
@teolemon teolemon added ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. and removed Stale labels Nov 24, 2023
@teolemon teolemon moved this to To discuss and validate in 🍊 Open Food Facts Server issues Apr 23, 2024
@teolemon teolemon removed the 🐛 bug This is a bug, not a feature request. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗄 Obsolete products ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.
Projects
Status: To discuss and validate
Development

No branches or pull requests

3 participants