Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable Polish ingredients processing + tests #8331

Merged
merged 2 commits into from
Apr 19, 2023
Merged

feat: Enable Polish ingredients processing + tests #8331

merged 2 commits into from
Apr 19, 2023

Conversation

stephanegigandet
Copy link
Contributor

Continuation of #8327 by @Teiron

  • added a stop word so that POD tests pass
  • added some unit tests

@stephanegigandet stephanegigandet requested a review from a team as a code owner April 18, 2023 11:55
@github-actions github-actions bot added 🥗 Ingredients 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients - processing 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests labels Apr 18, 2023
@stephanegigandet stephanegigandet mentioned this pull request Apr 18, 2023
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #8331 (3c9d51b) into main (b2f9b1d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8331   +/-   ##
=======================================
  Coverage   48.16%   48.16%           
=======================================
  Files         109      109           
  Lines       21015    21015           
  Branches     4739     4739           
=======================================
  Hits        10122    10122           
  Misses       9618     9618           
  Partials     1275     1275
Impacted Files Coverage Δ
lib/ProductOpener/Ingredients.pm 90.71% <ø> (ø)
tests/unit/ingredients_processing.t 93.33% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

alexgarel
alexgarel approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexgarel alexgarel changed the title Enable Polish processing + tests feat: Enable Polish ingredients processing + tests Apr 19, 2023
@alexgarel alexgarel merged commit 6bb43ea into main Apr 19, 2023
@alexgarel alexgarel deleted the polish-processing branch April 19, 2023 10:11
@alexgarel
Copy link
Member

thanks @Teiron for initiating this PR :-)

@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Apr 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
🥗 Ingredients - processing 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephanegigandet @codecov-commenter @alexgarel @Teiron