feat: export packaging data #8359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Data import
🧽 Data quality
alexgarel
approved these changes
Apr 25, 2023
| { | ||
| $j++; | ||
| if (defined $packaging_ref->{$field}) { | ||
| my $field_sort_key = sprintf("%08d", $group_number * 1000 + $i * 10 + $j); |
There was a problem hiding this comment.
can you add a comment to explain this $field_sort_key ?
(also above).
also why don't you use $field_sort_key . "_$j" like on line 272 ?
There was a problem hiding this comment.
There's a comment a bit above:
# %populated_fields will contain the field name as the key,
# and a sort key as the value so that the CSV columns are in the order of $options{import_export_fields_groups}
my %populated_fields = ();
There was a problem hiding this comment.
I'll add another comment for packagings:
# Generate a sort key so that the packaging fields in the CSV file are in this order:
# - all fields for packaging component 1, then all fields for packaging component 2
# - number_of_units, shape, material etc. (same a for loop above)
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is needed to export packagings data from the producers platform to the public platform.